Add-ons/Reviewers/MiscCannedResponses: Difference between revisions

This is a bit of a clipboard for the most active editors that need access to some not-very-frequently used canned responses.  

== For Video Downloader Add-ons  ==

If you plan to significantly differentiate your add-on from the others, we encourage you to continue working on it and submit again once you have produced a more unique offering.

== Altering DOM by textually modifying innerHTML  ==

I find I'm using this more often than I could have expected:

You alter the markup of documents by textually modifying their innerHTML. This causes the entire document to be re-parsed, which aside from the inefficiency has critical drawbacks, including invalidating any JavaScript reference to replaced DOM nodes, clearing any JavaScript properties and event listeners on replaced DOM nodes, re-executing any script tags in the changed markup, and causing said scripts to fail if they rely on document.write. Please create and alter DOM nodes with DOM methods such as createElement and replaceChild, and the textContent rather than innerHTML property.

</blockquote>

=== HTML  ===

<blockquote>Your add-on creates DOM nodes with raw HTML strings containing unsanitized string data. While the recommended method of creating DOM nodes is to use JavaScript DOM building methods such as createElement and appendChild (see https://developer.mozilla.org/en/How_to_create_a_DOM_tree) or one of the libraries which simplify using this method, creating content via strings is allowed if non-static data is sanitized with a function such as the following: <br> <pre>function escapeHTML(str) str.replace(/[&amp;"&lt;&gt;]/g,

You need to URL encode your GET query parameters with the encodeURIComponent function so that characters like&nbsp;%, &amp;, and # are not misinterpreted.

Splicing unquoted strings into SQL statements is always error prone and dangerous when that data is from a remote source. Please use parameter placeholders instead: https://developer.mozilla.org/en/storage#section_8

</blockquote>

The ShortName element must have a value not longer than 16 characters.

Your add-on makes it impossible for a user to permanently remove its toolbar button, which we can't allow. Inserting your toolbar button at first run is fine, and recommended, but doing so at every startup or making it impossible to move or remove it is not.

Your add-on makes remote, synchronous XMLHttpRequests which have the ability to lock-up the browser UI and are not allowed in public add-ons. Please use asynchronous requests instead.

Your add-on calls the setTimeout or setInterval functions with string rather than function arguments, which is normally not allowed. For instance, setTimeout('object.doStuff()',1) should be written as setTimeout(function () { object.doStuff() },1) instead.

<blockquote>p.s. you might want to investigate if using ctypes or rewriting as a NPAPI plugin would work for your addon instead. <br>If so then the binaries wouldn't need recompiling for each Firefox release.<br> <pre>ctypes:

== Approval Notes  ==

Please do _NOT_ copy Version Notes into Approval Notes, as we can see both in the queue. Approval notes are optional and only necessary if there are any exceptions you need to communicate to us reviewers.

</blockquote>  

=== Repeated Warnings  ===

<blockquote>If you chose to ignore any of our requests (e.g. because you needed to quickly release a bugfix) please use the Approval Notes fields to supply us with more information.</blockquote>