Firefox/Input/Standalone Feedback Button: Difference between revisions

update status
(update status)
 
(10 intermediate revisions by 5 users not shown)
Line 1: Line 1:
{| class="fullwidth-table"
{{FeatureStatus
|-
|Feature name=Provide a standalone feedback button
| style="font-weight: bold; background: #DDD;" | Feature
|Feature stage=Planning
| style="font-weight: bold; background: #DDD;" | Status
|Feature status note=Patch Incoming
| style="font-weight: bold; background: #DDD;" | ETA
}}
| style="font-weight: bold; background: #DDD;" | Owner
{{FeatureTeam
|-
|Feature product manager=Asa Dotzler
<section begin="status" />
|Feature feature manager=Aakash Desai
| [[Firefox/Input/Standalone Feedback Button|Provide a standalone feedback button ]]
|Feature lead engineer=Jono Xia
| {{StatusHealthy|status=Patch Incoming}}
|Feature qa lead=Vlad Ghetiu (irc: vladg)
| YYYY-MM-DD
}}
| aakashd
{{FeaturePageBody
<section end="status" />
|Feature open issues and risks=* The code in Test Pilot currently looks at ''every'' loaded URL to see whether or not it's an Input website where data is to be filled in.  This may be a performance issue, so we should test its impact and replace it with something more efficient if needed.
|-
* If the user has manually placed the Feedback button, should that preference override the channel setting?  (I.e. the customization remains even if you switch channels?)
|}
|Feature overview=The Feedback button (which is currently added to the toolbar in the Firefox aurora/beta branches by the bundled Test Pilot add-on) will be moved into Firefox where it becomes part of the default Toolbar Customization panel.
 
== Summary ==
The Feedback button (which is currently added to the toolbar in the Firefox aurora/beta branches by the bundled Test Pilot add-on) will be moved into Firefox where it becomes part of the default Toolbar Customization panel.


It will need to be added to the toolbar by default on Nightly, Aurora and Beta builds.  On Release builds it would not be added by default but the user could choose to add it through the Customization panel.
It will need to be added to the toolbar by default on Nightly, Aurora and Beta builds.  On Release builds it would not be added by default but the user could choose to add it through the Customization panel.
Line 22: Line 19:
The button holds a drop-down menu containing two items, "Firefox made me happy because..." and "Firefox made me sad because...", both of which go to the Input website and pre-fill some fields.
The button holds a drop-down menu containing two items, "Firefox made me happy because..." and "Firefox made me sad because...", both of which go to the Input website and pre-fill some fields.


== Team ==
<table class="fullwidth-table">
Who's working on this?
<tr>
 
<td style="background-color: #efefef;">Menu Item</td>
* '''Feature Manager''': Aakash Desai
<td style="background-color: #efefef;">URL</td>
* '''Lead Developer''':  Jono Xia
</tr>
* '''QA''':
<tr>
* '''UX''':
<td>Firefox made me happy because...</td>
* '''Security''':
<td>http://input.mozilla.com/happy</td>
 
</tr>
== Release Requirements ==
<tr>
 
<td>Firefox made me sad because...</td>
'''Instancing the "Feedback" button'''
<td>http://input.mozilla.com/sad</td>
# On Nightly/Aurora/Beta builds, a button which opens a menu consisting of two options (i.e. "Firefox made me happy because..." and "Firefox made me sad because...") should be visible on the right hand side of the navigation toolbar by default.
</tr>
# On Release builds, the button should NOT be visible in the navigation toolbar. But it should be available within the toolbar customization palette to add to the browser UI.
</table>
#* If the user is running a "Beta" build, but chooses to remove the Feedback button through customization, it must not reappear on restart.
#* Switching channels must be supported -- The Feedback button has to appear when switching to Beta/Aurora and disappear when switching to Release. (Unless the user has manually modified its location, in which case the modification sticks regardless of channel?)
 
'''Using the menu items'''
# When either menu item is selected, the appropriate URLs should load and desired information should be pre-filled onto the page (i.e. URL field will include the URL of the previously loaded tab and user agent will be pre-loaded onto a hidden form field).


{| class="fullwidth-table"
'''Ride-Along'''
|-
The URL attached to the "Submit Feedback..." menu item in the Help Menu is [http://mxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#471 hard-coded into the codebase], it'd be good to change it into a pref for testing purposes.
| style="background-color: #efefef;" | Menu Item
| style="background-color: #efefef;" | URL
|-
| Firefox made me happy because...
| http://input.mozilla.com/happy
|-
| Firefox made me sad because...
| http://input.mozilla.com/sad
|-
| Help -> Submit Feedback... ('''follow-along''')
| http://input.mozilla.com/feedback
|}


'''Externalities'''
'''Externalities'''
Line 63: Line 43:
#* "Firefox made me happy because..."
#* "Firefox made me happy because..."
#* "Firefox made me sad because..."
#* "Firefox made me sad because..."
 
|Feature users and use cases=* Users who wish to keep providing Input about Firefox through the feedback button should be able to do so even on the release channel with no bundled add-ons.
== Next Steps ==
* Separate Feedback button code from Test Pilot add-on and turn it into a patch against mozilla-central (Jono Xia)
 
== Open Issues ==
* The code in Test Pilot currently looks at ''every'' loaded URL to see whether or not it's an Input website where data is to be filled in.  This may be a performance issue, so we should test its impact and replace it with something more efficient if needed.
* If the user has manually placed the Feedback button, should that preference override the channel setting?  (I.e. the customization remains even if you switch channels?)
 
== Related Bugs & Dependencies ==
* {{bug|649156}} - Add the feedback button to the customize toolbar palette
 
== Test Plans ==
TODO - Any and all test plans and strategies.  Either inline or linked to.
 
== Goals/Use Cases ==
* Users who wish to keep providing Input about Firefox through the feedback button should be able to do so even on the release channel with no bundled add-ons.
* The Test Pilot add-on should be independent of the Feedback button implementation (which allows Test Pilot to become a restartless add-on).
* The Test Pilot add-on should be independent of the Feedback button implementation (which allows Test Pilot to become a restartless add-on).
* Input's "/feedback" page should be referred as a pref
|Feature requirements='''Instancing the "Feedback" button'''
# On Nightly/Aurora/Beta builds, a button which opens a menu consisting of two options (i.e. "Firefox made me happy because..." and "Firefox made me sad because...") should be visible on the right hand side of the navigation toolbar by default.
# On Release builds, the button should NOT be visible in the navigation toolbar. But it should be available within the toolbar customization palette to add to the browser UI.
#* If the user is running a "Beta" build, but chooses to remove the Feedback button through customization, it must not reappear on restart.
#* Switching channels must be supported -- The Feedback button has to appear when switching to Beta/Aurora and disappear when switching to Release. (Unless the user has manually modified its location, in which case the modification sticks regardless of channel?)


== Non-Goals ==
'''Using the menu items'''
# Placing the feedback button onto the navigation toolbar by default across all channels/builds.
# When either menu item is selected, the appropriate URLs should load and desired information should be pre-filled onto the page (i.e. URL field will include the URL of the previously loaded tab and user agent will be pre-loaded onto a hidden form field).
|Feature non-goals=# Placing the feedback button onto the navigation toolbar by default across all channels/builds.
# Landing Test Pilot as a patch onto mozilla-central.
# Landing Test Pilot as a patch onto mozilla-central.
|Feature qa review=TODO - Any and all test plans and strategies.  Either inline or linked to.
|Feature implementation notes=* {{bug|649156}} - Add the feedback button to the customize toolbar palette


__NOTOC__
==== Next steps ====
 
* Separate Feedback button code from Test Pilot add-on and turn it into a patch against mozilla-central (Jono Xia)
Please remove this line and any non-relevant categories below.  Add whatever other categories you feel are appropriate.
}}
 
{{FeatureInfo
[[Category:Features]]
|Feature priority=P2
[[Category:Firefox]]
|Feature roadmap=User Engagement
|Feature list=Desktop
|Feature engineering team=Desktop front-end
}}
{{FeatureTeamStatus}}
Confirmed users
933

edits