Confirmed users
1,198
edits
BMO/Development Processes: Difference between revisions
→Reviews
(Created page with " == Interaction Between BMO and Upstream == === Security/Blocker Issues === * If filed against BMO, we should also file and possibly provide a fix for upstream * If filed aga...") |
|||
| Line 27: | Line 27: | ||
=== Reviews === | === Reviews === | ||
* The review should perform an "eyes-only" review within one working day | * The review should perform an "eyes-only" review within one working day | ||
** This | ** This involves reading the code and commenting if things look OK, or r-'ing if there are obvious issues | ||
* Non-executable code does not require review (documentation, comments) | * Non-executable code does not require review (documentation, comments) | ||
* Judgement call on if patches require review, with a strong bias towards asking for a review | * Judgement call on if patches require review, with a strong bias towards asking for a review | ||