139
edits
Media/WebRTC/Up-streaming Changes: Difference between revisions
Media/WebRTC/Up-streaming Changes (view source)
Revision as of 17:58, 17 August 2023
, 17 August 2023Splitting the bug submission and review upload into their own subsections as per the outline
(Correct the name of the google bug tracker and the google code review tool) |
(Splitting the bug submission and review upload into their own subsections as per the outline) |
||
| Line 22: | Line 22: | ||
It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | It is very likely that one will need to write a libwebrtc unit test that covers the code change, or alter a unit test to pass with the new code change. The unit test should ideally run correctly on both the main branch and the release branch that Firefox is using. | ||
===Opening An up-stream Bug=== | ===Opening An up-stream Bug=== | ||
One will need to file a bug for one's fix under the appropriate component in the [https://bugs.chromium.org/p/webrtc/issues/list WebRTC Monorail instance]. In the bug one may mention that there is a fix that has been shipped in Firefox, and include a link to the | |||
===Submitting An up-stream Patch=== | ===Submitting An up-stream Patch=== | ||
* libwebrtc uses [http://webrtc-review.googlesource.com/ this Gerrit instance] to track reviews. Note the ID of the bug that Monorail generated as one will need to use that ID in the commit message of your proposed fix. One's git commit message should include a line that reads `BUG=webrtc:xxxx`, where xxxx is the bug ID from Monorail. | |||
===Requesting A Reviewer=== | ===Requesting A Reviewer=== | ||
In the past we have emailed our contact at google seeking reviews for specific bugs. | In the past we have emailed our contact at google seeking reviews for specific bugs. | ||
| Line 32: | Line 35: | ||
===After The Code Is Landed Up-stream=== | ===After The Code Is Landed Up-stream=== | ||
Now that the code is landed up-stream there are two more steps that one needs perform. Firstly, in the Mozilla repo one will create a backout patch for the code that was up-streamed. Secondly, one will create a cherry-pick patch from the upstream release. | Now that the code is landed up-stream there are two more steps that one needs perform. Firstly, in the Mozilla repo one will create a backout patch for the code that was up-streamed. Secondly, one will create a cherry-pick patch from the upstream release. | ||
==Tracking Progress== | ==Tracking Progress== | ||
There is a [https://docs.google.com/spreadsheets/d/1C9lg12ZQrctDU89zHB_bsni9pYTD7Ojos_7tq64Bjqs/edit#gid=0 spreadsheet] to track the progress of our in progress up-stream patches. | There is a [https://docs.google.com/spreadsheets/d/1C9lg12ZQrctDU89zHB_bsni9pYTD7Ojos_7tq64Bjqs/edit#gid=0 spreadsheet] to track the progress of our in progress up-stream patches. | ||