308
edits
DOM/WebIDL Review Checklist: Difference between revisions
Adding note about JSContext.
(→Spec makes sense: add secure context requirement) |
(Adding note about JSContext.) |
||
| Line 32: | Line 32: | ||
* Implementation should use the argument types described in [https://developer.mozilla.org/en/Mozilla/WebIDL_bindings our binding layer documentation], not whatever internal types bindings are using (e.g. no types in the <code>binding::detail</code> namespace, no <code>NonNull<T></code> arguments where <code>T&</code> would work, etc). | * Implementation should use the argument types described in [https://developer.mozilla.org/en/Mozilla/WebIDL_bindings our binding layer documentation], not whatever internal types bindings are using (e.g. no types in the <code>binding::detail</code> namespace, no <code>NonNull<T></code> arguments where <code>T&</code> would work, etc). | ||
* Check that the <code>GetParentObject()</code> methods of various objects, combined with how those objects get constructed, associate them with the correct global. | * Check that the <code>GetParentObject()</code> methods of various objects, combined with how those objects get constructed, associate them with the correct global. | ||
* Any <code>JSContext</code>s being used by the implementation come from the right places (passed in, <code>AutoJSAPI</code>, <code>AutoEntryScript</code>, depending on the desired semantics). | |||
== Further reading == | == Further reading == | ||