3,035
edits
Update:Archive/1.0/Developers: Difference between revisions
Update:Archive/1.0/Developers (view source)
Revision as of 17:26, 18 February 2005
, 18 February 2005→/update/VersionCheck.php
| Line 532: | Line 532: | ||
** Code comments indicate 1-6, checks provide IDs 0,2,3,4,5,6 | ** Code comments indicate 1-6, checks provide IDs 0,2,3,4,5,6 | ||
** Use logic to create short-circuit; right now it's all if's so the checks will happen even after a match is found and $osid is set -- logically, it's possible for $osid to be set twice | ** Use logic to create short-circuit; right now it's all if's so the checks will happen even after a match is found and $osid is set -- logically, it's possible for $osid to be set twice | ||
* [234] Query in a loop. Remove this. This | * [234] Query in a loop. Remove this. This could be replaced with an IN( explode(','$reqItemGuid) ) instead of $reqItemGuid[$i] in the query (assuming some checks on $reqItemGuid before the explode()), reducing the number of queries from count($reqItemGuid) to 1 since $osid and $reqTargetAppGuid are the same. | ||
* [253] Is there any way to avoid this OR ? | * [253] Is there any way to avoid this OR ? | ||