308
edits
DOM/WebIDL Review Checklist: Difference between revisions
Jump to navigation
Jump to search
Note that webidl review should consider exposure
(Adding note about JSContext.) |
(Note that webidl review should consider exposure) |
||
| Line 1: | Line 1: | ||
A review checklist for DOM Peers while doing WebIDL reviews. This is not exhaustive; things will be added as needed. | A review checklist for DOM Peers while doing WebIDL reviews. This is not exhaustive; things will be added as needed. | ||
The general idea of WebIDL review is to review the interface, spec, and implementation of something before we expose it to the web. | |||
== IDL follows spec == | == IDL follows spec == | ||
| Line 23: | Line 25: | ||
== Implementation is correct == | == Implementation is correct == | ||
* Check that the new implementation is exposed in the right places (e.g. test-only stuff not being exposed to the web, things that should be behind prefs actually being behind prefs, etc). | |||
* Check that the implementation follows the spec, as much as is possible without domain expertise. | * Check that the implementation follows the spec, as much as is possible without domain expertise. | ||
* All functions with non-nullable return values must never return null. | * All functions with non-nullable return values must never return null. | ||