308
edits
DOM/WebIDL Review Checklist: Difference between revisions
Jump to navigation
Jump to search
[Replaceable] should be used as needed
(Note that webidl review should consider exposure) |
([Replaceable] should be used as needed) |
||
| Line 14: | Line 14: | ||
* The API should be easy to understand and use, and consistent. | * The API should be easy to understand and use, and consistent. | ||
* There should be an [https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement intent to implement] for the feature, and the reviewer should not be objecting to the intent. In particular, this means checking whether other UAs plan to implement this spec, and if not why we're doing it. | * There should be an [https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Implement intent to implement] for the feature, and the reviewer should not be objecting to the intent. In particular, this means checking whether other UAs plan to implement this spec, and if not why we're doing it. | ||
* New readonly properties on global scopes should almost certainly be <code>[Replaceable]</code> to not break sites using variables or functions with a colliding name. This is especially salient for short names. | |||
* Whether things are nullable or not needs to make sense. | * Whether things are nullable or not needs to make sense. | ||
* Whether arguments and dictionary members are optional or not needs to make sense. | * Whether arguments and dictionary members are optional or not needs to make sense. | ||