3,035
edits
Update:Archive/1.0/Developers: Difference between revisions
→/plugins
| Line 525: | Line 525: | ||
===/plugins=== | ===/plugins=== | ||
* In general, it's not in CVS which is bad. | |||
** We know what part can't be in CVS (uniqueUrl.php), so it will be committed soon. | |||
* Why isn't this information in a database? | |||
** If there was a mime-type to file data map along with some mappings for compatibility, this could be a much simpler script. | |||
** On that note, why can't the existing UMO database be used with the addition of a mime-type table and a mime-type to version map? | |||
** If a query with LIMIT 1 could happen, the overhead for this script would be reduced because there wouldn't be so many preg_match calls and string comparisons, which gets pretty expensive when you've got them in a series of if-else's. | |||
* How do people update their plug-ins? Can they? (doesn't look like it) | |||
* Logging is going to | |||
====/plugins/index.php==== | ====/plugins/index.php==== | ||
---- | ---- | ||
====/plugins/download.php==== | |||
* [61-78] PHP is not for serving files. Use a redirect that sends them to a URL instead. | |||
---- | |||
====/plugins/PluginFinderService.php==== | |||
* [57][92] Functions that are declared but never used. | |||
* [50] The infamous bail() function has no purpose. | |||
* [42-45] DB information is stored in this file. Why??? | |||
* [47] This should be a require_once(). | |||
* [394] This could be done more thoroughly with a built-in PHP function instead of using preg_replace. | |||
---- | |||
====/plugins/uniqueUrl.php==== | |||
* Can't change this. | |||
---- | |||
===/rss=== | ===/rss=== | ||
====/rss/inc_rssfeed.php==== | ====/rss/inc_rssfeed.php==== | ||