3,035
edits
Update:Archive/1.0/Developers: Difference between revisions
→/update/VersionCheck.php
| Line 585: | Line 585: | ||
* [234] Query in a loop. Remove this. This could be replaced with an IN( implode(','$reqItemGuid) ) instead of $reqItemGuid[$i] in the query (assuming some checks on $reqItemGuid before the implode()), reducing the number of queries from count($reqItemGuid) to 1 since $osid and $reqTargetAppGuid are the same. (alanjstr says: good catch. This is new code, so it only handles 1 at a time right now) | * [234] Query in a loop. Remove this. This could be replaced with an IN( implode(','$reqItemGuid) ) instead of $reqItemGuid[$i] in the query (assuming some checks on $reqItemGuid before the implode()), reducing the number of queries from count($reqItemGuid) to 1 since $osid and $reqTargetAppGuid are the same. (alanjstr says: good catch. This is new code, so it only handles 1 at a time right now) | ||
* [253] Is there any way to avoid this OR ? | * [253] Is there any way to avoid this OR ? | ||
* The mime-type "text/rdf" should be "text/xml". | |||